Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure string isn't empty to prevent going out of bounds #2585

Merged
merged 1 commit into from Apr 8, 2024

Conversation

harels
Copy link
Member

@harels harels commented Apr 5, 2024

Problem

String lookup was not accounting for empty strings and causing java.lang.StringIndexOutOfBoundsException.

Solution

Make sure string isn't empty first.

One-line summary:

Checklist

  • You've signed-off your work
  • Your pull request title follows our guidelines
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
  • You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
  • You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

Signed-off-by: Harel Shein <harel.shein@datadoghq.com>
@boring-cyborg boring-cyborg bot added the area:client/java openlineage-java label Apr 5, 2024
@pawel-big-lebowski pawel-big-lebowski merged commit 145de87 into main Apr 8, 2024
67 checks passed
@pawel-big-lebowski pawel-big-lebowski deleted the fix-out-of-bounds-exception branch April 8, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:client/java openlineage-java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants