add custom token provider support #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:client/java
There was a problem hiding this comment.
Hi @tnazarew, so happy to see you back here. Thanks for preparing the amazing PR! 🥇
|
|
||
| @NoArgsConstructor | ||
| @ToString | ||
| public class FakeTokenProvider implements TokenProvider { |
There was a problem hiding this comment.
you can try it as static class within ArgumentParserTest if you like
| public JavaType typeFromId(DatabindContext context, String id) { | ||
| Class<?> subType = null; | ||
| if (Objects.equals(id, "api_key")) // backwards compatibility | ||
| return context.constructSpecializedType(superType, ApiKeyTokenProvider.class); |
There was a problem hiding this comment.
don't forget our old friend Spotless
There was a problem hiding this comment.
funny thing is, when you forget to put curly brackets after if, spotless doesn't even recognise it as incorrect and spotlessApply changes indentation to what you can see here
tnazarew
force-pushed
the
spark/custom-token-provider-support
branch
2 times, most recently
from
2d18071
to
e14dcb9
Compare
pawel-big-lebowski
force-pushed
the
spark/custom-token-provider-support
branch
from
91f5a5b
to
5a400cf
Compare
pawel-big-lebowski
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
OL didn't have a support for custom token providers
Closes: #2542
Solution
TokenProviderTypeIdResolverwas added to handle both FQCN and (for backward compatibility)api_keytype inspark.openlineage.transport.auth.typeOne-line summary:
Checklist
SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project