Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search/filter functionality to object selection window #1837

Merged
merged 19 commits into from Feb 16, 2023
Merged

Add search/filter functionality to object selection window #1837

merged 19 commits into from Feb 16, 2023

Commits on Feb 12, 2023

  1. TextInput: fix handleInput when no input length limit is set

    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    1f9bae7 View commit details
    Browse the repository at this point in the history

  2. ObjectSelectionWindow: add full text input functionality

    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    7b4b17e View commit details
    Browse the repository at this point in the history

  3. ObjectSelectionWindow: rename _tabInformation to _tabPositions

    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    2f12968 View commit details
    Browse the repository at this point in the history

  4. ObjectSelectionWindow: rename _50D144 to _objectSelection

    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    fdac3e7 View commit details
    Browse the repository at this point in the history

  5. ObjectSelectionWindow: rename _52334{A,C} to _mousePos{X,Y}

    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    b7a8990 View commit details
    Browse the repository at this point in the history

  6. ObjectSelectionWindow: rename sub_472BBC to getFirstAvailableSelected… 

    …Object
    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    2aa7bd8 View commit details
    Browse the repository at this point in the history

  7. ObjectSelectionWindow: cache vector with object list for current tab

    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    3d770e8 View commit details
    Browse the repository at this point in the history

  8. ObjectSelectionWindow: implement case-insensitive filtering

    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    08190bf View commit details
    Browse the repository at this point in the history

  9. ObjectSelectionWindow: keep visibility into account in getObjectFromS… 

    …election
    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    33e647a View commit details
    Browse the repository at this point in the history

  10. ObjectSelectionWindow: only count visible objects for getScrollSize

    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    cbb177d View commit details
    Browse the repository at this point in the history

  11. Amend changelog

    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    e148476 View commit details
    Browse the repository at this point in the history

  12. Keyboard: allow using screenshot shortcut in object selection window,… 

    … still
    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    150239c View commit details
    Browse the repository at this point in the history

  13. drawSearchBox: reuse rather than shadow a local

    @AaronVanGeffen
    AaronVanGeffen committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    73d3494 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Add 'Clear' button next to text input

    @AaronVanGeffen
    AaronVanGeffen committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    6a151b9 View commit details
    Browse the repository at this point in the history

  2. Construct pattern directly from buffer, no need to go through c_str

    @AaronVanGeffen
    AaronVanGeffen committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    f353bce View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @AaronVanGeffen
    AaronVanGeffen committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    e597e4e View commit details
    Browse the repository at this point in the history

  4. Reserve space in vector before iterating over objects

    @AaronVanGeffen
    AaronVanGeffen committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    a3d4118 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. populateTabObjectList: apply std::move to entry

    @AaronVanGeffen
    AaronVanGeffen committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    620c306 View commit details
    Browse the repository at this point in the history

  2. Use enum class to denote visibility

    @AaronVanGeffen
    AaronVanGeffen committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    f76660f View commit details
    Browse the repository at this point in the history