Add search/filter functionality to object selection window #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronVanGeffen
force-pushed
the
objsel/filter
branch
from
674b51d
to
883f7c9
Compare
AaronVanGeffen
commented
Feb 15, 2023
| @@ -342,6 +342,16 @@ namespace OpenLoco::Input | |||
| } | |||
| } | |||
|
|
|||
| ti = WindowManager::find(WindowType::objectSelection); | |||
| if (ti != nullptr) | |||
There was a problem hiding this comment.
I think we should start handling these through the window manager, ideally passing through to an event for the active window only. Something for a future PR though.
There was a problem hiding this comment.
Yeah i was a bit confused as to what this was about.
AaronVanGeffen
commented
Feb 15, 2023
AaronVanGeffen
commented
Feb 15, 2023
AaronVanGeffen
commented
Feb 15, 2023
AaronVanGeffen
force-pushed
the
objsel/filter
branch
from
f016822
to
f76660f
Compare
duncanspumpkin
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces search/filter functionality to the object selection window, performing case-insensitive string matching on the visible name and object filenames.
Matches by visible name:
Or by object filename:
