Start separating game and engine code #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| using coord_t = int16_t; | ||
| using tile_coord_t = int16_t; |
There was a problem hiding this comment.
that reminds me. Basically nothing uses tile_coord_t. It has some users for z which should use the SmallZ/MicroZ types and it has some users for a tile coordinate which should be using TilePos2.
|
I take it engine has that empty file just to force it to generate something? |
Yeah, it may or may not be removed again once actual code is compiled there. |
duncanspumpkin
approved these changes
Feb 16, 2023
AaronVanGeffen
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get the ball rolling on a better structure in overall it's best to split the game from the engine. The game is responsible for its objects, mechanics, entities, ui and so on while the engine is the thing that should store and manage those things for the game. Right now we should first separate concerns of game and engine into the Engine library before further slicing the engine into sub components such as renderer, audio, input, network etc. I think this approach is easier than figuring out already what sub components are in the engine.