Promote use of internal progress bars #2411
Merged
+100
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal progress bars weren't displaying at all due to recent changes in the graphics stack (OpenLoco#1766). The progress bars use Gfx::renderAndUpdate to refresh the screen, but after this refactor, only SoftwareDrawingEngine::render was being called, but the SoftwareDrawingEngine::present it introduced was not. This left the screen not updated.
AaronVanGeffen
changed the title
AaronVanGeffen
commented
Apr 9, 2024
LeftofZen
approved these changes
Apr 10, 2024
AaronVanGeffen
force-pushed
the
fix/internal-progress-bars
branch
2 times, most recently
from
34f85bd
to
3455f8c
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal progress bars weren't displaying at all due to recent changes in the graphics stack (#1766). The progress bars use
Gfx::renderAndUpdateto refresh the screen, but after this refactor, onlySoftwareDrawingEngine::renderwas being called, but theSoftwareDrawingEngine::presentit introduced was not. This left the screen un-updated.In addition to this, I reshuffled the main
OpenLoco::initialisefunction to prioritise G1 loading and GUI init, such that we now have internal progress bars for the object and scenario indexing processes. Getting to G1 init happens so quickly, I believe we can just do away with the remaining Win32 ones.