Introduce render context #1766
Introduce render context #1766
Conversation
|
I will have to get this a bit cleaner, instead of passing around the render target it should now pass the render context which holds an active render target, that will eliminate all the temporary getRenderContext calls. |
ZehMatt
force-pushed
the
render-context
branch
from
a75eef4
to
226e88c
Compare
ZehMatt
force-pushed
the
render-context
branch
from
226e88c
to
63445f6
Compare
ZehMatt
force-pushed
the
render-context
branch
3 times, most recently
from
b6ae09c
to
9fe4f64
Compare
ZehMatt
force-pushed
the
render-context
branch
from
9fe4f64
to
f37a284
Compare
|
Unfortunately I can't refactor the RenderTarget argument just yet, there are some external functions that are missing and there might be shared use of the global render target instance. This has to do as a first pass until the rest is solved. |
| } | ||
| } // Impl | ||
|
|
||
| void SoftwareDrawingContext::clear(Gfx::RenderTarget& rt, uint32_t fill) |
There was a problem hiding this comment.
what is the reasoning behind this indirection? Why not just implement clear here?
There was a problem hiding this comment.
Because at the moment everything passes RenderTarget but the context does not have its own state currently, I tried to do that but ran into a road block, the plan is to do eliminate that once we can do that.
|
@AaronVanGeffen are you want a check as well. |
The internal progress bars weren't displaying at all due to recent changes in the graphics stack (OpenLoco#1766). The progress bars use Gfx::renderAndUpdate to refresh the screen, but after this refactor, only SoftwareDrawingEngine::render was being called, but the SoftwareDrawingEngine::present it introduced was not. This left the screen not updated.
Closes #1762