Retry hook installation #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisozaur
force-pushed
the
mkinst-and-his-old-wine
branch
from
749659e
to
074fd20
Compare
This can happen on some versions of wine which would fail on WriteProcessMemory calls with specific addresses. Skipping to next entry works just fine.
janisozaur
force-pushed
the
mkinst-and-his-old-wine
branch
from
074fd20
to
eb86ed9
Compare
|
Odd thing about this is I tried calling |
|
We know why it failed in the first place? |
|
There are documented instances of such failures with wine. I haven't checked what (if anything) changed there. |
duncanspumpkin
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues seen by MK Inst on his prehistoric wine