Updated message from config check of unconnected inputs #1095
Conversation
naylor-b
commented
Oct 30, 2019
naylor-b
commented
- now includes units and values
- any cases where the values for connected inputs don't match are highlighted
| template_prom.format(a, u, | ||
| _trim_str(problem.get_val(a, | ||
| get_remote=True), | ||
| 25), |
There was a problem hiding this comment.
This is really hard to read. Could you create a temporary variable to hold _trim_str(problem.get_val(a,get_remote=True) to improve readability? Added advantage, looks like you can do it outside of the if branch.
| a = absnames[0] | ||
| msg.append(" " + | ||
| template_abs.format(a, units[0], | ||
| _trim_str(problem.get_val(a, get_remote=True), |
There was a problem hiding this comment.
Wonder if we should return the norm instead of the full array for large arrays. Maybe optionally.
There was a problem hiding this comment.
Which is the better default, norm or truncated value? We can't pass options to specific checks via the command line. We could make it an option to the internal check function I suppose, but that won't help with command line usage since it would require the user to use some complicated syntax.
There was a problem hiding this comment.
i don't know, maybe we should do both truncated and norm...
There was a problem hiding this comment.
ok I updated it to use the norm if the string exceeds the specified width.
