New tests for N2 GUI #1152
New tests for N2 GUI #1152
Conversation
.travis.yml
Outdated
| testflo -n 1 openmdao --coverage --coverpkg openmdao --cover-omit \*tests/\* --cover-omit \*devtools/\* --cover-omit \*test_suite/\* --cover-omit \*docs/\* --cover-omit \*code_review/\*; | ||
| else | ||
| testflo -n 1 --timeout=120 openmdao; | ||
| - if [ -z "$SKIP_TESTFLO" ]; then |
There was a problem hiding this comment.
could just use -z "$GUI" here and no need for SKIP_TESTFLO, right?
There was a problem hiding this comment.
Having both allows for it to be tested in any other combo in the matrix by putting GUI=1 in that row - for instance in addition to/instead of testing standalone, we might want to test it with the Python 3.6 row because it usually completes faster.
.travis.yml
Outdated
| @@ -11,16 +11,21 @@ filter_secrets: false | |||
| os: | |||
| - linux | |||
|
|
|||
| # language: node_js | |||
|
|
|||
| # node_js: node | |||
There was a problem hiding this comment.
these commented lines can be deleted?
There was a problem hiding this comment.
Yes, didn't need that anymore after I changed it so it only installs Node.js when GUI=1
|
Since it's not a Python package, I'm having a lot of trouble getting Node.js into setup.py so it would install with [test] or [all]. I'm thinking that because the GUI tests run outside of testflo, they should have their own script to kick them off, and that could check for the presence of node and automatically install if necessary. |
|
@tadkollar : I wonder if there is something @naylor-b can do to testflo to give it the capability to run the GUI tests. |
Syncing with master
|
AppVeyor keeps failing on the Python 2.7 build with:
Not sure why that's happening, doesn't seem to be anything to do with my changes... |
This update performs headless browser testing on N2 HTML files generated from the models stored in n2_viewer/tests/gui_test_models. It consists of a Node script, test_gui.js, a set of model-specific tests in gui_scripts.json, and several test models. There's a set of toolbar tests that can be performed on any model. Changes were made to .travis.yml to install Node and add another test matrix row to test the GUI. Some changes were also made to the N2 source code to make sure each element had an id attrib.
Here's what the output on Travis looks like:
travis_output.txt