Several N2 appearance changes #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
moved this from In progress
to Under review
in OpenMDAO Dev [Read only]
… button when hovered
hschilling
approved these changes
May 28, 2020
project-bot
bot
moved this from Reviewer approved
to Under review
in OpenMDAO Dev [Read only]
robfalck
requested changes
Jun 8, 2020
|
|
robfalck
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are several N2 updates:
The issue with the weird variable name highlighting is addressed by drawing a vertical line next to the variable name with the same color as the node, similar to the method used in Excel.
The info panel is now pinnable. When using info-panel mode and a node is left-clicked, the panel is pinned and won't change when the mouse moves off the node. To unpin the panel, either left-click on another node, click the pushpin on the panel, or exit info-panel mode.
Connection nodes in the matrix are now represented by a gray, curved arrow instead of a black square. The arrow makes it obvious that the connections and variables are different entities, and the gray color doesn't contrast as harshly with the rest of the diagram colors.
Connection arrows now curve through the connection nodes instead of forming a right angle with a dot at the vertex.
Resolves Coloring and highlighting of items in the N2 hierarchy can be confusing #1362
Resolves N2 info panel should be pinnable #1410
Backwards incompatibilities
None
New Dependencies
None