Pinned N2 arrows are now transitioned between updates #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request OpenMDAO#1490 from tadkollar/n2compress1489
…nto n2arrow1387
…nto n2arrow1387
Fixed problem of arrows disappearing after transition followed by cell hover.
…nto n2arrow1387
project-bot
bot
moved this from In progress
to Under review
in OpenMDAO Dev [Read only]
hschilling
approved these changes
Jul 24, 2020
swryan
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was a substantial change because connection arrows were previously not managed except through selectors in the DOM. There's now an arrow manager object that maintains caches of hovered and pinned arrows, migrates arrows between them, and regenerates arrows that have changed (e.g. due to their endpoints going offscreen or collapsing).
Pinned N2 connection arrows will now be preserved when elements are zoomed in or out, collapsed or uncollapsed, the document is resized, or any other update. If a collapsed element has pinned arrows, all of its children will have arrows when it's uncollapsed. Arrows with endpoints that have gone completely offscreen will be hidden, but be restored when either endpoint returns.
The connection-related toolbar buttons have changed also. The "show all connections in model" button has become the "show and pin all connections in current view" button. The "hide connections" button has become the "remove all pinned arrows in the model" button. The "show connections" button has been removed.
Tests were updated to reflect id name changes and arrow counts in certain situations.
Related Issues
Backwards incompatibilities
None
New Dependencies
None