Replaced N2 & doc instances of param/unknown with input/output #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenneth-T-Moore
requested changes
Jul 28, 2020
openmdao/drivers/scipy_optimizer.py
Outdated
| for param in ('minimizer_kwargs', 'sampling_method ', 'n', 'iters'): | ||
| if param in self.opt_settings: | ||
| kwargs[param] = self.opt_settings[param] | ||
| for input in ('minimizer_kwargs', 'sampling_method ', 'n', 'iters'): |
There was a problem hiding this comment.
Instead of 'input' replace these ones with 'option'.
openmdao/drivers/scipy_optimizer.py
Outdated
| for input in self._designvars.values(): | ||
| size = input['global_size'] if input['distributed'] else input['size'] | ||
| ninput += size | ||
| x_init = np.empty(ninput) |
There was a problem hiding this comment.
to be technical, let's replace these with 'ndesvar' and 'desvar' instead of input.
openmdao/surrogate_models/kriging.py
Outdated
| @@ -131,7 +131,7 @@ def train(self, x, y): | |||
|
|
|||
There was a problem hiding this comment.
Revert all of these changes in kriging.py. The use of param here has nothing to do with openmdao inputs. It's the kriging model hyperparameters.
project-bot
bot
moved this from In progress
to Under review
in OpenMDAO Dev [Read only]
Kenneth-T-Moore
approved these changes
Jul 29, 2020
swryan
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The N2 code and several areas of the docs still referenced param/unknown terms instead of input/output. These were updated, and a few other areas of N2 code were cleaned up as well.
Related Issues
Backwards incompatibilities
None
New Dependencies
None