Impl. PR for POEM_029 - Retrieval of IO Variable Metadata #1577
Conversation
…ehavior for distrib vars
naylor-b
added
the
Pending POEM Acceptance
There was a problem hiding this comment.
The code looks good to me, but the one big test I noted has some pretty tough to decifer code. Can you at least add a few doc strings or comments?
I know you were reducing code duplication, but I was having trouble decifering the asserts. I think other developers would struggle to discern the correct expected behavior if the test broke and they had to fix it.
openmdao/core/configinfo.py
Outdated
|
|
||
| def _descendents(mysystem, sysiter): | ||
| """ | ||
| Iterate over system ancestors, but include only mysystem's descendents. |
There was a problem hiding this comment.
suggest clarification: `Filter given iterator of system paths to include only mysystem's descendents
| import numpy as np | ||
| import openmdao.api as om | ||
|
|
||
| class FlightDataComp(om.ExplicitComponent): |
There was a problem hiding this comment.
interesting component names here. Did these come from some reduced dymos test case?
There was a problem hiding this comment.
I assume so. This test was already there and I just modified it.
swryan
removed
the
Pending POEM Acceptance
Impl from PR #1577 but reverted return value of list_inputs/list_outputs back to lists
Summary
Adds the
get_io_metadatamethod to System and modifieslist_inputsandlist_outputsto use it internally.This is only an initial implementation and will have further updates prior to POEM_029 approval.
Related Issues
Backwards incompatibilities
New Dependencies
None