add equivalent unit conversion check and tests #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenneth-T-Moore
approved these changes
Sep 17, 2020
naylor-b
requested changes
Sep 17, 2020
openmdao/core/group.py
Outdated
| errs.add('units') | ||
| metadata.add('units') | ||
| try: | ||
| test_conv = unit_conversion(sunits, tunits) |
There was a problem hiding this comment.
Since PhysicalUnit objects understand if they're equivalent or not, we could do this a little more cleanly:
if _find_unit(sunits) != _find_unit(tunits):
errs.add('units')
metadata.add('units')
_find_unit is found in openmdao.utils.units
openmdao/core/tests/test_units.py
Outdated
| z={'value': 1.0, 'units': 'J/s'}), | ||
| promotes_inputs=['x', 'z']) | ||
| # trying to convert J/s/s to m/s**2 should cause Incompatible units TypeError exception | ||
| with self.assertRaises(TypeError): |
There was a problem hiding this comment.
We should check the contents of the error message here as well.
|
The requested changes have been made. |
naylor-b
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Variables promoted with equivalent but different units (such as 'm/s/s' vs. 'm/s**2' will raise an exception without set_input_defaults. Before raising the exception, make sure the units not equivalent.
Related Issues
Backwards incompatibilities
None
New Dependencies
None