Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of internal data structures and some cleanups. #1693

Merged
merged 52 commits into from
Sep 21, 2020
Merged

Refactor of internal data structures and some cleanups. #1693

merged 52 commits into from
Sep 21, 2020

Conversation

naylor-b
Copy link
Member

  • _var*abs2meta split into input/output subdicts
  • removed _varabs_names. Now using the ordered iteration of _varabs2meta
  • small speedups/cleanups to ExecComp getitem/setitem
  • _setup_var_sizes now only does Allgather for nonlinear sizes and uses nonlinear sizes to determine all other size arrays
  • changed _setup_var_index_maps to be callable for each vec_name
  • removed _loc_subsys_map
  • removed _subsystems_var_range
  • removed _subsystems_inds
  • _subsystems_allprocs is now an ordered dict with entries containing the system and its index
  • added a get_source function to reduce the need for direct access to stuff in system._problem_meta
  • fixed units related error messages to include unit strings

@naylor-b
removed abs_names_discrete and reduced data being gathered in setup_v…
14030fa 
…ar_data
@naylor-b
remove allprocs_abs_names from allgather
84b095e
@naylor-b
cleanup
5372a28
@naylor-b
merged out
1be2307
@naylor-b
tests passing
0c8069a
@naylor-b
interim
e89eb94
@naylor-b
interim
afdd679
@naylor-b
tests passing
2b4a8c6
@naylor-b
Merge branch 'list_io_in_config' into combo
0d34e0c
@naylor-b
interim
e8f2371
@naylor-b
tests passing
6019e0d
@naylor-b
merged out
6e4b064
@naylor-b
tests passing
ccec334
@naylor-b
cleanup
25bd549
@naylor-b
cleanup
59cd702
@naylor-b
cleanup
80d2026
@naylor-b
interim
bc86c9b
@naylor-b
tests passing
8be4c2c
@naylor-b
got rid of loc_subsys_map
f21aa3c
@naylor-b
cleanup
e2cf98b
@naylor-b
reverted inclusion of size calculation in component._setup_var_data
4e25661
@naylor-b
merged out
59b7800
@naylor-b
numpy n2 fix
97dbd7e
@naylor-b
vec_name cleanup
c0e6c05
@naylor-b
all test passing
684b645
@naylor-b
cleanup
8a43b6f
@naylor-b
cleanup
a2a9420
@naylor-b
merged out
df3fc49
@naylor-b
Merge remote-tracking branch 'origin/master' into move_sizes
4cd6967
@naylor-b
tests pass
c1d3622
@project-bot project-bot bot added this to In progress in OpenMDAO Dev [Read only] Sep 21, 2020
OpenMDAO Dev [Read only] automation moved this from In progress to Reviewer approved Sep 21, 2020
@swryan swryan merged commit e18df7c into OpenMDAO:master Sep 21, 2020
OpenMDAO Dev [Read only] automation moved this from Reviewer approved to Done Sep 21, 2020
@relf relf mentioned this pull request Sep 21, 2020
Closed
@anilyil anilyil mentioned this pull request Oct 22, 2020
Closed
2 tasks
hschilling pushed a commit to hschilling/OpenMDAO that referenced this pull request Feb 24, 2021
@naylor-b
Fixes to work with OpenMDAO PR OpenMDAO#1693 (OpenMDAO#396)
f3739aa 
* fix for removal of _loc_subsys_map

* getting rid of direct access to model_ref
@naylor-b naylor-b deleted the refactor branch March 8, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kenneth-T-Moore Kenneth-T-Moore Kenneth-T-Moore approved these changes

@swryan swryan swryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OpenMDAO Dev [Read only]
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@naylor-b @Kenneth-T-Moore @swryan