Fixed show_progress error #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenneth-T-Moore
approved these changes
Dec 9, 2020
swryan
reviewed
Dec 16, 2020
| @@ -2586,6 +2587,10 @@ def test_check_totals_show_progress(self): | |||
| lines = stream.getvalue() | |||
| self.assertFalse("Checking derivatives with respect to" in lines) | |||
|
|
|||
| msg = "'_ReprClass' object has no attribute 'write'" | |||
| with assert_no_warning(AttributeError, msg): | |||
| prob.check_totals(method='fd', show_progress=True) | |||
There was a problem hiding this comment.
you don't need the assert here.. just doing the check_totals without specifying an out_stream suffices to show that it's working.. (it fails with a hard error without your fix... the assert doesn't do anything)
swryan
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed show_progress error
Related Issues
show_progressargument in compute_totals #1786Backwards incompatibilities
None
New Dependencies
None