N2 window code consolidation #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NodeInfo panel functionality
…tooltip z-index, fixed value window min size
…ed tests for new N2Window code, reduced N2 toolbar testing
hschilling
approved these changes
Feb 5, 2021
swryan
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The N2 diagram had implemented four different types of windowing systems (help, legend, node info, and value info) with redundant code in several areas. This update merges the redundant functionality into N2Window, N2WindowDraggable, and N2WindowResizable classes and derives the previous functionality from each.
There were also updates to the GUI tests to prevent deprecation warnings, and new tests for the updated windowing system were added.
Related Issues
Backwards incompatibilities
None
New Dependencies
None