Case Recording Alpha #296
Case Recording Alpha #296
Conversation
…e_recorder_file.py
All tests pass
…at_top # Conflicts: # openmdao/devtools/problem_viewer/problem_viewer.py
…er and update filename expectations. Now passing path to view_model rather than simply its name
Fix viz tests
Fix viz tests v2
| @@ -194,15 +270,29 @@ def get_constraint_values(self, ctype='all', lintype='all'): | |||
| Default is 'all'. Optionally return just the linear constraints | |||
| with 'linear' or the nonlinear constraints with 'nonlinear'. | |||
|
|
|||
| filter : list | |||
| List of objective names used by recorders. | |||
There was a problem hiding this comment.
For this method in the doctstring, objective --> constraint
There was a problem hiding this comment.
ARGGGH, stupid copy/paste errors! Fixed locally.
| @@ -2605,15 +2618,6 @@ def _solve_linear(self, vec_names, mode): | |||
| list of names of the right-hand-side vectors. | |||
| mode : str | |||
| 'fwd' or 'rev'. | |||
|
|
|||
There was a problem hiding this comment.
This method is always overriden, and the versions of it in subclasses have these returns. Don't we want the parent class stubs to have the fully documented docstring args and returns? I don't know the answer, but what does eveyone think.
There was a problem hiding this comment.
Did I change this? Or are you just asking in general?
There was a problem hiding this comment.
Well I mean you deleted the "Returns" part of the docstring, but i am arguing that it should be restored because the child overrides return that stuff.
There was a problem hiding this comment.
OH, the diff I'm seeing looked like a blank line got deleted. I'll restore it. I'm not sure why that would have been on my radar to delete. Likely an error.
* replace load_case with re_interpolate_solution * add more error checking to test_load_case * fix pep8 complaints
No description provided.