Remove unused var opts in _setup_var_data, avoid potential memory waste

[SaltySodaBunny]

Summary

After checking the _setup_var_data, I verified the opts dictionary is unused.
I remove this variable and the assignment line for this variable.

Related Issues

• Resolves Unused code or missing arg? #2928

[Kenneth-T-Moore]

Need to check something.

[Kenneth-T-Moore]

Ok, yeah. It looks like this part came over from the interpolating spline component, where it is needed for the bspline options. Interp_options isn't implemented here, but could be useful for setting a couple of things in Akima. It should come in as a feature with tests and docs in the future. For now, removing the extra code is the right thing to do.

[coveralls]

coverage: 89.759% (-0.3%) from 90.045%
when pulling 6cd4e54 on SaltySodaBunny:test481
into 64ae0bf on OpenMDAO:master.

[SaltySodaBunny]

Thank you for the code reviewing, it's my first time contributing on an open source project. Currently, I can't merge pull request because this commit is not signed. How can I solve this issue?

[robfalck]

Could you please revert units.py to the same as the master version?

Those changes should be addressed in your other pull request but we shouldn't be introducing any of those changes in this one.

[swryan]

Thank you for the code reviewing, it's my first time contributing on an open source project. Currently, I can't merge pull request because this commit is not signed. How can I solve this issue?

See this page:
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

It is possible to retroactively sign commits, but with a single commit it is probably easier to just reset and redo the change after you have signing configured.

https://webdevstudios.com/2020/05/26/retroactively-sign-git-commits/

[robfalck]

We can clean up the ops issue and save the units changes for later.