Part 1 of setup refactor. #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naylor-b
approved these changes
Aug 1, 2017
JustinSGray
reviewed
Aug 1, 2017
| This method may optionally be overidden by your Group's method. | ||
|
|
||
| You may only use this method to change settings on your children subsystems. This includes | ||
| setting solvers in cases where you want to override the defaults. |
There was a problem hiding this comment.
I think we should include some detail about timing here.
"You can assume that the full hierarchy below your level has been instantiated and has already called its own configure methods."
JustinSGray
requested changes
Aug 1, 2017
openmdao/core/tests/test_problem.py
Outdated
|
|
||
| top['sub.comp.a'] = 1.5576015661428098 | ||
| top.run_model() | ||
| assert_rel_error(self, top['sub.comp.x'], -0.5) |
There was a problem hiding this comment.
should you explicitly test for the solve class here as well. Testing for convergence seems a round-about-way to know this worked here.
There was a problem hiding this comment.
also, the test could be a bit faster if we didn't actually have to run the solver. Since we're not testing solve behavior here, its not necessary and would even, I think make a better more unit-like test if we didn't run the solver
JustinSGray
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configurewhere users can make changes to their subsystems. These are recursed in reverse.setupcalled undersetup_procs.