removed setting of distributed metadata to False if nprocs==1 #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swryan
approved these changes
Feb 14, 2024
robfalck
approved these changes
Feb 14, 2024
|
Thanks for the super quick response @naylor-b! ⚡ |
|
Thanks to @timryanb for doing all of the work. |
|
No worries, glad I could help @naylor-b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The 'distributed' metadata was being set to False at the component level if nprocs there was 1, but higher up the system tree where nprocs > 1 it was incorrectly flagging a distrib/non-distrib mismatch because it thought the component variable was not distributed.
Related Issues
Backwards incompatibilities
None
New Dependencies
None