Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch aoa1, aoa2 back to vector aoa in supersonic panel example #167

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

Asthelen
Copy link
Collaborator

@Asthelen Asthelen commented Dec 5, 2023

Recent refactor of OpenMDAO derivatives has fixed this OM issue: OpenMDAO/OpenMDAO#2919 through this pull request: OpenMDAO/OpenMDAO#3069

As a workaround, a couple supersonic panel examples used aoa1 and aoa2 DVs instead of a vector aoa, due to incorrect derivatives. Derivatives are now correct with a vector aoa DV.

@timryanb timryanb self-requested a review December 6, 2023 11:24
@timryanb timryanb merged commit 75eafec into OpenMDAO:main Dec 6, 2023
1 check passed
@Asthelen Asthelen deleted the vector_aoa_fix branch December 6, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants