Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of reverse transfers and fixes for FD group that contains parallel group(s). #3069

Merged
merged 77 commits into from Dec 5, 2023

Conversation

naylor-b
Copy link
Member

Summary

  • Refactored reverse transfers so that internal derivative values are correct throughout the model instead of being off by some multiple, determined by the number of duplicated responses, which we previously corrected for at the end of the total derivative calculation.
  • Fixed an issue in both fwd and rev modes where total derivatives were incorrect in cases where a group using FD or CS contained a parallel group.
  • Added a command line tool to display the full set of connections across ranks when running under MPI.
  • Fixed a number of bugs that resulted from the way we were doing reverse transfers previously.

Related Issues

Backwards incompatibilities

This could break models where someone has added code to correct for the previously incorrect derivatives by dividing by the comm size or something similar.

New Dependencies

None

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coveralls
Copy link

coveralls commented Nov 14, 2023

Coverage Status

coverage: 89.75% (-0.3%) from 90.021%
when pulling 6e16d7c on naylor-b:transfers5
into fee4510 on OpenMDAO:master.

openmdao/vectors/vector.py Outdated Show resolved Hide resolved
@naylor-b naylor-b marked this pull request as ready for review December 4, 2023 16:24
@swryan swryan merged commit 51f1873 into OpenMDAO:master Dec 5, 2023
8 checks passed
@naylor-b naylor-b deleted the transfers5 branch March 14, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants