added env var to tell other code when it's running under testflo #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swryan
approved these changes
Feb 14, 2022
| @@ -144,6 +144,9 @@ def dir_exclude(d): | |||
| return True | |||
| return False | |||
|
|
|||
| # set this so code will know when it's running under testflo | |||
There was a problem hiding this comment.
Should you restore the env var after testflo finishes? (Or is this being set on the spawned processes?)
There was a problem hiding this comment.
The environment variable appears not to persist even if not explicitly removed. For example, for this python code
import os
os.environ['FOOBAZ'] = '1'
print("FOOBAZ =", os.environ.get('FOOBAZ'))
After running this code and checking the current environment, FOOBAZ isn't found.
hschilling
approved these changes
Feb 14, 2022
Kenneth-T-Moore
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was originally in the PR that updates coverage, but that PR is held up because of some issue I haven't had time to look into yet. But Herb needs this now so I'm just splitting it out into its own PR.