Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOPPAS fixes #4780

Merged
merged 7 commits into from
Jun 8, 2020
Merged

TOPPAS fixes #4780

merged 7 commits into from
Jun 8, 2020

Conversation

cbielow
Copy link
Contributor

@cbielow cbielow commented Jun 8, 2020

  1. fix 'FileNotWritable' exception in TOPPAS when temporary filenames only differ in case (upper vs lower) and thus renaming deletes the source (18e8d07)

  2. [FIX] prevent Exception from skipping over important cleanup code (might lead to inoperable pipelines which cannot be executed anymore) (57581e2)

…ly differ in case (upper vs lower) and thus renaming deletes the source
…e at the end of a scope (no matter if exceptions occurred)
…ght lead to inoperable pipelines which cannot be executed anymore)
@timosachsenberg
Copy link
Contributor

feel free to merge

@cbielow cbielow merged commit eb60687 into OpenMS:develop Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants