[FEATURE] added filtering for protein group scores #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/topp/IDFilter.cpp
Outdated
| @@ -157,7 +157,7 @@ class TOPPIDFilter : | |||
| registerTOPPSubsection_("score", "Filtering by peptide/protein score."); | |||
| registerDoubleOption_("score:pep", "<score>", 0, "The score which should be reached by a peptide hit to be kept.", false); | |||
| registerDoubleOption_("score:prot", "<score>", 0, "The score which should be reached by a protein hit to be kept. Use in combination with 'delete_unreferenced_peptide_hits' to remove affected peptides.", false); | |||
|
|
|||
| registerDoubleOption_("score:protgroup", "<score>", 0, "The score which should be reached by a protein group to be kept. Use in combination with 'delete_unreferenced_peptide_hits' to remove affected peptides.", false); | |||
There was a problem hiding this comment.
don't know maybe this needs a bit more explanation what the difference between score:prot and score:protgroup is.
Would it even make sense to just use score:prot and have the new semantics?
There was a problem hiding this comment.
No, I think it is important if people actually care about specific isoforms to filter for single protein scores.
Hmm.. I think the difference is clear, the question is whether people know the implications.
There was a problem hiding this comment.
I wouldn't say for the casual user.
E.g., is it clear that score:protgroup includes single proteins? Most would probably guess no
timosachsenberg
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.