Fix isWithinMaxRange function in AiTravel [0.45.0 regression] #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this is a regression for 0.45, not caused by recastnavigation. Glad we got that cleared up. :) |
|
cherry-picked to 0.45 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the major problem brought in (surprisingly) by actor processing optimization and not recastnavigation introduction: AiTravel is completely broken.
isWithinMaxRange was using incorrect type for AI processing range so it almost always returned false, breaking AiTravel. JDGBOLT discovered this.
This should be cherry-picked to 0.45.0 branch. I wanted to make some cleanup but it was too specific to recastnavigation pathfinding.