Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento logo in error display #1589

Closed
ProxiBlue opened this issue May 2, 2021 · 5 comments · Fixed by #1599
Closed

Magento logo in error display #1589

ProxiBlue opened this issue May 2, 2021 · 5 comments · Fixed by #1599
Labels
bug good first issue easy to solve issues

Comments

@ProxiBlue
Copy link
Contributor

ProxiBlue commented May 2, 2021

Preconditions (*)

  1. 19.4.5

Steps to reproduce (*)

  1. Beak something to thrown an exception

Expected result (*)

  1. OpenMage logo

Actual result (*)

  1. https://github.com/OpenMage/magento-lts/blob/1.9.4.x/errors/default/images/logo.gif is magento logo
  2. image
  3. Copyright message of Magento in text
@ProxiBlue ProxiBlue added the bug label May 2, 2021
@Flyingmana Flyingmana added the good first issue easy to solve issues label May 2, 2021
@ADDISON74
Copy link
Contributor

The /errors directory has not been "brushed" so far. The error reporting pages should also be reviewed in the next OM versions.

@fballiano
Copy link
Contributor

fballiano commented May 3, 2021

@colinmollenhour @Flyingmana is there a high def version of the OpenMage logo? Can't find it anywhere.

Also, the logo on the website is different from the one in the actual source:
Schermata 2021-05-03 alle 20 42 28
Schermata 2021-05-03 alle 20 42 23

IMHO the website version is much better, less colors, easier to covert and rescale, no shadows that can't be converted in gif (magento's source is full of gif versions of the logos)

@colinmollenhour
Copy link
Member

I don't have the source handy but can get it if needed. However the version on the homepage is svg so you can just zoom way in and take a screenshot. :)

image

@fballiano
Copy link
Contributor

I've donwloaded the SVG logo, embedded the font and converted it to (trimmed and transparent) PNG e GIF (with 4 colors only).

I'm attaching them here for future reference:
logo
logo

(I wanted to upload the ZIP and SVG but github doesn't allow me).

I'll update the source code with the new version of the logo.

@fballiano
Copy link
Contributor

Actually I just found out that the logo is already in the source code: https://github.com/OpenMage/magento-lts/blob/1.9.4.x/skin/adminhtml/default/openmage/images/logo.svg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue easy to solve issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants