Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded docblock method definition #1067

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Remove unneeded docblock method definition #1067

merged 1 commit into from
Jun 30, 2020

Conversation

tmotyl
Copy link
Contributor

@tmotyl tmotyl commented Jun 26, 2020

The method getFormKey() exists in Mage_Core_Block_Abstract, so no need to define it with @method

The method getFormKey() exists in Mage_Core_Block_Abstract, so no need to define it with `@method`
Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to fix these little errors step by step or wait for my planned 2nd cleanup?

@sreichel sreichel added Cleanup: DOC blocks Related to DOC block updates and fixes. Component: Core Relates to Mage_Core labels Jun 26, 2020
@tmotyl
Copy link
Contributor Author

tmotyl commented Jun 27, 2020

@sreichel I dont know your plan in details. Ive just stumbled upon this one and fixed it.
If you have bigger chenge in your stash lets close this one to avoid conflicts.

@sreichel
Copy link
Contributor

There is no detailed plan (nor a stash) yet ... i just wait for the last docs updates get merged and then i'd continue. We should merge this one of course, but there is no need to make many small PRs that could/will be solved during next weeks.

@sreichel
Copy link
Contributor

sreichel commented Jun 27, 2020

Planned so far ...

  • wait for the PRs get merged
  • add missing ones (still 12 modules like Adminhtml, Paypal, ... w/o PR left)
  • start 2nd (final) round for doc-blocks ... fix errors/improve unclear docs (mixed/object/....)
  • re-start tests with phpstan
  • add global CS fixes
  • add phpcbf to workflow
  • hopefully done ... ;)

@tmotyl tmotyl merged commit 33cc824 into 1.9.4.x Jun 30, 2020
@sreichel sreichel deleted the tmotyl-patch-1 branch September 3, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup: DOC blocks Related to DOC block updates and fixes. Component: Core Relates to Mage_Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants