Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: disable fixerio in config #1098

Merged
merged 4 commits into from
Jul 24, 2020
Merged

Cleanup: disable fixerio in config #1098

merged 4 commits into from
Jul 24, 2020

Conversation

kkrieger85
Copy link
Contributor

@kkrieger85 kkrieger85 commented Jul 7, 2020 •
edited by sreichel

Description (*)

Update config file to disable fixerio service by default

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Disable fixer.io service by default #1094

Manual testing scenarios (*)

  1. Login to Backend -> System -> Configuration -> Currency setup
  2. Open Fixer.io Tab
  3. Enabled should be "no"

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

fballiano
fballiano reviewed Jul 8, 2020
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change in the "disable fixerio in config" PR?

@fballiano
Copy link
Contributor

Am I mistaken or some of the commits are not related to the PR?

@kkrieger85
Copy link
Contributor Author

@fballiano I forgot to rebase before I made this change.
Commits should be ignored as changes will be "squash and merged"

@colinmollenhour colinmollenhour merged commit 3d5444f into OpenMage:1.9.4.x Jul 24, 2020
@sreichel sreichel added Component: Directory Relates to Mage_Directory enhancement labels Jul 25, 2020
@sreichel sreichel added this to the Release 20.0.2 / 19.4.6 milestone Aug 7, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
@edannenberg
[impr-OpenMage#1098] Disable fixerio in default config
7b10e0e
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 24, 2020
@edannenberg
[impr-OpenMage#1098] Disable fixerio in default config
2c32292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano left review comments

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@sreichel sreichel sreichel approved these changes

Assignees
No one assigned
Labels
Component: Directory Relates to Mage_Directory enhancement
Projects
None yet
Milestone
Release 19.4.6 / 20.0.2
Development

Successfully merging this pull request may close these issues.

Disable fixer.io service by default
4 participants
@kkrieger85 @fballiano @colinmollenhour @sreichel