Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove php short open tag #1279

Merged
merged 1 commit into from Oct 22, 2020
Merged

Remove php short open tag #1279

merged 1 commit into from Oct 22, 2020

Conversation

luigifab
Copy link
Collaborator

Description

This replace the 3 latest short open tag in app directory.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog Component: Reports Relates to Mage_Reports Template : rwd Relates to rwd template labels Oct 22, 2020
@kkrieger85 kkrieger85 merged commit 13602b4 into OpenMage:1.9.4.x Oct 22, 2020
@kkrieger85 kkrieger85 added hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) hacktoberfest-accepted labels Oct 28, 2020
@sreichel sreichel added the Cleanup: Code style Related to simple CS fixes. label Dec 27, 2020
@sreichel sreichel added this to the Release 19.4.9 / 20.0.5 milestone Dec 27, 2020
@luigifab luigifab deleted the remove-short-open-tag branch January 1, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flyingmana Flyingmana Flyingmana approved these changes

@kkrieger85 kkrieger85 kkrieger85 approved these changes

@sreichel sreichel sreichel approved these changes

Assignees
No one assigned
Labels
Cleanup: Code style Related to simple CS fixes. Component: Catalog Relates to Mage_Catalog Component: Reports Relates to Mage_Reports hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) hacktoberfest-accepted Template : rwd Relates to rwd template
Projects
None yet
Milestone
Release 19.4.9 / 20.0.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luigifab @Flyingmana @kkrieger85 @sreichel