Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PHPDoc #1323

Merged
merged 1 commit into from Nov 29, 2020
Merged

Improve PHPDoc #1323

merged 1 commit into from Nov 29, 2020

Conversation

aredridel
Copy link
Contributor

@aredridel aredridel commented Nov 27, 2020 •
edited

Description (*)

A very simple change to fully annotate the join method. The underlying join supports more types than the PHPDoc suggests.

Manual testing scenarios (*)

There should be no testing required as it is strictly documentation change and strictly widening the types.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Nov 27, 2020
@Flyingmana Flyingmana merged commit 9195974 into OpenMage:1.9.4.x Nov 29, 2020
@aredridel aredridel deleted the fix-phpdoc-join branch November 30, 2020 14:34
@sreichel sreichel added the Cleanup: DOC blocks Related to DOC block updates and fixes. label Dec 27, 2020
@sreichel sreichel added this to the Release 19.4.9 / 20.0.5 milestone Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@sreichel sreichel sreichel approved these changes

Assignees
No one assigned
Labels
Cleanup: DOC blocks Related to DOC block updates and fixes. Component: Core Relates to Mage_Core
Projects
None yet
Milestone
Release 19.4.9 / 20.0.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aredridel @colinmollenhour @sreichel @Flyingmana