Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the documentation Hint "(?)" functionality #1536

Merged
merged 5 commits into from
Apr 17, 2021

Conversation

fballiano
Copy link
Contributor

This PR replaces #1519 because I couldn't add a commit to that one (because of a technical problem).

The only difference is this new commit:
753f461
which removes an unused constant.

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Component: Newsletter Relates to Mage_Newsletter Component: Page Relates to Mage_Page Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Template : admin Relates to admin template translations Relates to app/locale labels Apr 9, 2021
Copy link
Collaborator

@Sekiphp Sekiphp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for new PR :-)

@fballiano
Copy link
Contributor Author

@colinmollenhour and @Flyingmana sorry to bother, we had your positive review on the original version of this PR, could you take a look at this new version? it's exactly the same thing, plus a single mega-easy commit:
753f461

thanks! :-)

Copy link
Member

@Flyingmana Flyingmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other commits are identical to the referenced PR

@Flyingmana Flyingmana merged commit ced97cd into OpenMage:20.0 Apr 17, 2021
@Flyingmana Flyingmana changed the title Remove hints Remove the documentation Hint "(?)" functionality Apr 17, 2021
@github-actions
Copy link

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ced97cd. ± Comparison against base commit 89e1c6f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Component: Newsletter Relates to Mage_Newsletter Component: Page Relates to Mage_Page Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Template : admin Relates to admin template translations Relates to app/locale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants