Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style (endif and break) #1577

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Code style (endif and break) #1577

merged 1 commit into from
Apr 30, 2021

Conversation

fballiano
Copy link
Contributor

In PR #1035 a couple of things missing, so I added them here

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Giftmessage Relates to Mage_Giftmessage Component: Page Relates to Mage_Page Template : admin Relates to admin template Template : base Relates to base template labels Apr 29, 2021
@fballiano fballiano mentioned this pull request Apr 29, 2021
Merged
3 tasks
@Flyingmana Flyingmana merged commit 90a0fe2 into OpenMage:1.9.4.x Apr 30, 2021
@github-actions
Copy link

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  4 ✔️ ±0  0 💤 ±0  2 ❌ ±0 

Results for commit 90a0fe2. ± Comparison against base commit 5a0b657.

luigifab pushed a commit to luigifab/magento-lts that referenced this pull request May 13, 2021
@fballiano @luigifab
In PR OpenMage#1035 <?php break; ?> was missing (OpenMage#1577)
f67f24e 
Co-authored-by: Fabrizio Balliano <fabrizio@fabrizioballiano.com>
@fballiano fballiano deleted the code-style-2 branch May 28, 2021 15:29
@luigifab luigifab mentioned this pull request Jun 25, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@kkrieger85 kkrieger85 kkrieger85 approved these changes

@luigifab luigifab luigifab approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Giftmessage Relates to Mage_Giftmessage Component: Page Relates to Mage_Page Template : admin Relates to admin template Template : base Relates to base template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fballiano @kiatng @kkrieger85 @luigifab @Flyingmana