Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed origData is empty in a quote #1735

Merged
merged 2 commits into from Jul 20, 2021
Merged

Conversation

woutersamaey
Copy link
Contributor

@woutersamaey woutersamaey commented Jul 15, 2021

Description (*)

_origData is empty when quotes are loaded though

  • loadByIdWithoutStore()
  • loadActive()
  • loadByCustomer()

When loading a quote with load(), then _origData is filled, but only in that case.

Fixed Issues (if relevant)

This fixed change detection and is important for my module because origData is always NULL on the cart page and several other locations.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

`_origData` is empty when quotes are loaded though 
- loadByIdWithoutStore()
- loadActive()
- loadByCustomer()
When loading a quote with load(), then `_origData` is available, but only then.
@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Jul 15, 2021
@woutersamaey
Copy link
Contributor Author

Can we get this moving along @Flyingmana @colinmollenhour @sreichel ?

@Flyingmana
Copy link
Member

@woutersamaey did you check what would happen, if any data changes during the collectTotals() which is called in the `_afterLoad``?
If I see it right, this would currently lead to them not get persisted if something changes there.
Thats probably ok, as anything which does a relevant change, would call the collectTotals again, also the normal load() would cause the same.

@woutersamaey
Copy link
Contributor Author

@Flyingmana this does not matter. Like you said yourself, it's the same as with the regular load() so no issue here. I'm just following what Magento itself does.

@Flyingmana Flyingmana merged commit 6571d9a into OpenMage:20.0 Jul 20, 2021
@github-actions
Copy link

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  6 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6571d9a. ± Comparison against base commit 3fbc99a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Relates to Mage_Sales
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants