Some changes for compatibility with PHP 8.1

app/Mage.php

@@ -421,7 +421,8 @@ public static function getStoreConfig($path, $store = null)
      */
     public static function getStoreConfigFlag($path, $store = null)
     {
-        $flag = strtolower(self::getStoreConfig($path, $store));
+        $flag = self::getStoreConfig($path, $store);
+        $flag = is_string($flag) ? strtolower($flag) : $flag;
         if (!empty($flag) && 'false' !== $flag) {
             return true;
         } else {

app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php

@@ -140,8 +140,8 @@ public function getStoreLastLoginDateTimezone()
     public function getCurrentStatus()
     {
         $log = $this->getCustomerLog();
-        if ($log->getLogoutAt() ||
-            strtotime(now())-strtotime($log->getLastVisitAt())>Mage_Log_Model_Visitor::getOnlineMinutesInterval()*60) {
+        if ($log->getLogoutAt() || (!empty($log->getLastVisitAt()) &&
+            (strtotime(now()) - strtotime($log->getLastVisitAt()) > Mage_Log_Model_Visitor::getOnlineMinutesInterval() * 60))) {
             return Mage::helper('customer')->__('Offline');
         }
         return Mage::helper('customer')->__('Online');

app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column.php

@@ -206,7 +206,8 @@ public function setRenderer($renderer)
 
     protected function _getRendererByType()
     {
-        $type = strtolower($this->getType());
+        $type = $this->getType();
+        $type = is_string($type) ? strtolower($type) : $type;
         $renderers = $this->getGrid()->getColumnRenderers();
 
         if (is_array($renderers) && isset($renderers[$type])) {
@@ -301,7 +302,8 @@ public function setFilter($filterClass)
 
     protected function _getFilterByType()
     {
-        $type = strtolower($this->getType());
+        $type = $this->getType();
+        $type = is_string($type) ? strtolower($type) : $type;
         $filters = $this->getGrid()->getColumnFilters();
         if (is_array($filters) && isset($filters[$type])) {
             return $filters[$type];

app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Abstract.php

@@ -94,7 +94,8 @@ protected function _getHtmlId()
      */
     public function getEscapedValue($index = null)
     {
-        return htmlspecialchars($this->getValue($index));
+        $value = $this->getValue($index);
+        return is_string($value) ? htmlspecialchars($value) : $value;
     }
 
     /**

app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Abstract.php

@@ -107,8 +107,9 @@ public function renderHeader()
     {
         if (false !== $this->getColumn()->getGrid()->getSortable() && false !== $this->getColumn()->getSortable()) {
             $className = 'not-sort';
-            $dir = strtolower($this->getColumn()->getDir());
-            $nDir= ($dir=='asc') ? 'desc' : 'asc';
+            $dir  = $this->getColumn()->getDir();
+            $dir  = is_string($dir) ? strtolower($dir) : $dir;
+            $nDir = ($dir == 'asc') ? 'desc' : 'asc';
             if ($this->getColumn()->getDir()) {
                 $className = 'sort-arrow-' . $dir;
             }

app/code/core/Mage/Core/Helper/Abstract.php

@@ -215,7 +215,7 @@ public function escapeHtml($data, $allowedTags = null)
             }
         } else {
             // process single item
-            if (strlen($data)) {
+            if (is_string($data) && (strlen($data) > 0)) {
                 if (is_array($allowedTags) && !empty($allowedTags)) {
                     $allowed = implode('|', $allowedTags);
                     $result = preg_replace('/<([\/\s\r\n]*)(' . $allowed . ')([\/\s\r\n]*)>/si', '##$1$2$3##', $data);

app/code/core/Mage/Core/Helper/String.php

@@ -187,7 +187,7 @@ public function str_split($str, $length = 1, $keepWords = false, $trim = false,
             }
         } // split smartly, keeping words
         else {
-            $split = preg_split('/(' . $wordSeparatorRegex . '+)/siu', $str, null, PREG_SPLIT_DELIM_CAPTURE);
+            $split    = preg_split('/(' . $wordSeparatorRegex . '+)/siu', $str, -1, PREG_SPLIT_DELIM_CAPTURE);
             $i        = 0;
             $space    = '';
             $spaceLen = 0;

app/code/core/Mage/Core/Model/Config.php

@@ -1273,7 +1273,7 @@ public function getGroupedClassName($groupType, $classId, $groupRootNode = null)
         // First - check maybe the entity class was rewritten
         $className = null;
         if (isset($config->rewrite->$class)) {
-            $className = (string)$config->rewrite->$class;
+            $className = trim((string) $config->rewrite->$class);
         } else {
             /**
              * Backwards compatibility for pre-MMDB extensions.
@@ -1284,13 +1284,11 @@ public function getGroupedClassName($groupType, $classId, $groupRootNode = null)
                 $deprecatedNode = $config->deprecatedNode;
                 $configOld = $this->_xml->global->{$groupType.'s'}->$deprecatedNode;
                 if (isset($configOld->rewrite->$class)) {
-                    $className = (string) $configOld->rewrite->$class;
+                    $className = trim((string) $configOld->rewrite->$class);
                 }
             }
         }
 
-        $className = trim($className);
-
         // Second - if entity is not rewritten then use class prefix to form class name
         if (empty($className)) {
             if (!empty($config)) {
@@ -1317,7 +1315,7 @@ public function getGroupedClassName($groupType, $classId, $groupRootNode = null)
      */
     public function getBlockClassName($blockType)
     {
-        if (strpos($blockType, '/')===false) {
+        if (strpos($blockType, '/') === false) {
             return $blockType;
         }
         return $this->getGroupedClassName('block', $blockType);
@@ -1367,11 +1365,13 @@ public function getResourceHelper($moduleName)
      */
     public function getModelClassName($modelClass)
     {
-        $modelClass = trim($modelClass);
-        if (strpos($modelClass, '/')===false) {
-            return $modelClass;
+        if (empty($modelClass)) {
+            return '';
+        }
+        if (strpos($modelClass, '/') === false) {
+            return trim($modelClass);
         }
-        return $this->getGroupedClassName('model', $modelClass);
+        return $this->getGroupedClassName('model', trim($modelClass));
     }
 
     /**

app/code/core/Mage/Core/Model/Design/Package.php

@@ -537,7 +537,7 @@ public function getSkinUrl($file = null, array $params = array())
         Varien_Profiler::start(__METHOD__);
 
         // Prevent reading files outside of the proper directory while still allowing symlinked files
-        if (strpos($file, '..') !== false) {
+        if (is_string($file) && (strpos($file, '..') !== false)) {
             Mage::log(sprintf('Invalid path requested: %s (params: %s)', $file, json_encode($params)), Zend_Log::ERR);
             throw new Exception('Invalid path requested.');
         }

app/code/core/Mage/Core/Model/Resource/Config.php

@@ -101,7 +101,7 @@ public function loadToXml(Mage_Core_Model_Config $xmlConfig, $condition = null)
             if ($r['scope'] !== 'default') {
                 continue;
             }
-            $value = str_replace($substFrom, $substTo, $r['value']);
+            $value = empty($r['value']) ? $r['value'] : str_replace($substFrom, $substTo, $r['value']);
             $xmlConfig->setNode('default/' . $r['path'], $value);
         }
 

app/code/core/Mage/Eav/Model/Attribute/Data/Multiline.php

@@ -135,7 +135,7 @@ public function outputValue($format = Mage_Eav_Model_Attribute_Data::OUTPUT_FORM
     {
         $values = $this->getEntity()->getData($this->getAttribute()->getAttributeCode());
         if (!is_array($values)) {
-            $values = explode("\n", $values);
+            $values = is_string($values) ? explode("\n", $values) : [];
         }
         $values = array_map(array($this, '_applyOutputFilter'), $values);
         switch ($format) {

app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php

@@ -638,7 +638,8 @@ public function getBackendTable()
             if ($this->isStatic()) {
                 $this->_dataTable = $this->getEntityType()->getValueTablePrefix();
             } else {
-                $backendTable = trim($this->_getData('backend_table'));
+                $backendTable = $this->_getData('backend_table');
+                $backendTable = is_string($backendTable) ? trim($backendTable) : $backendTable;
                 if (empty($backendTable)) {
                     $entityTable  = array($this->getEntity()->getEntityTablePrefix(), $this->getBackendType());
                     $backendTable = $this->getResource()->getTable($entityTable);

app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Time/Created.php

@@ -41,8 +41,8 @@ class Mage_Eav_Model_Entity_Attribute_Backend_Time_Created extends Mage_Eav_Mode
      */
     protected function _getFormat($date)
     {
-        if (is_string($date) && preg_match('#^\d{4,4}-\d{2,2}-\d{2,2}\s\d{2,2}:\d{2,2}:\d{2,2}$#', $date)
-            || preg_match('#^\d{4,4}-\d{2,2}-\d{2,2}\w{1,1}\d{2,2}:\d{2,2}:\d{2,2}[+-]\d{2,2}:\d{2,2}$#', $date)) {
+        if (is_string($date) && (preg_match('#^\d{4,4}-\d{2,2}-\d{2,2}\s\d{2,2}:\d{2,2}:\d{2,2}$#', $date)
+            || preg_match('#^\d{4,4}-\d{2,2}-\d{2,2}\w{1,1}\d{2,2}:\d{2,2}:\d{2,2}[+-]\d{2,2}:\d{2,2}$#', $date))) {
             return 'yyyy-MM-dd HH:mm:ss';
         }
         return null;

app/code/core/Mage/Eav/Model/Entity/Type.php

@@ -264,7 +264,8 @@ public function getValueTablePrefix()
      */
     public function getEntityTablePrefix()
     {
-        $tablePrefix = trim($this->_data['value_table_prefix']);
+        $tablePrefix = $this->_data['value_table_prefix'];
+        $tablePrefix = is_string($tablePrefix) ? trim($tablePrefix) : $tablePrefix;
 
         if (empty($tablePrefix)) {
             $tablePrefix = $this->getEntityTable();

app/design/adminhtml/default/default/template/widget/tabs.phtml

@@ -24,15 +24,15 @@
  * @license     http://opensource.org/licenses/afl-3.0.php  Academic Free License (AFL 3.0)
  */
 ?>
-<?php if($this->getTitle()): ?>
+<?php if ($this->getTitle()): ?>
     <h3><?php echo $this->getTitle() ?></h3>
 <?php endif ?>
-<?php if(!empty($tabs)): ?>
+<?php if (!empty($tabs)): ?>
 <ul id="<?php echo $this->getId() ?>" class="tabs">
 <?php foreach ($tabs as $_tab): ?>
 <?php if (!$this->canShowTab($_tab)): continue;  endif; ?>
-    <li <?php if($this->getTabIsHidden($_tab)): ?> style="display:none"<?php endif ?>>
-        <a href="<?php echo $this->getTabUrl($_tab) ?>" id="<?php echo $this->getTabId($_tab) ?>" name="<?php echo $this->getTabId($_tab, false) ?>" title="<?php echo Mage::helper('core')->quoteEscape($this->getTabTitle($_tab)) ?>" class="tab-item-link <?php echo $this->getTabClass($_tab) ?><?php if (preg_match('/\s?ajax\s?/', $_tab->getClass())) {?> notloaded<?php }?>">
+    <li <?php if ($this->getTabIsHidden($_tab)): ?> style="display:none"<?php endif ?>>
+        <a href="<?php echo $this->getTabUrl($_tab) ?>" id="<?php echo $this->getTabId($_tab) ?>" name="<?php echo $this->getTabId($_tab, false) ?>" title="<?php echo Mage::helper('core')->quoteEscape($this->getTabTitle($_tab)) ?>" class="tab-item-link <?php echo $this->getTabClass($_tab) ?><?php if (!empty($_tab->getClass()) && preg_match('/\s?ajax\s?/', $_tab->getClass())) {?> notloaded<?php }?>">
             <span><span class="changed" title="<?php echo Mage::helper('core')->quoteEscape($this->__('The information in this tab has been changed.')) ?>"></span><span class="error" title="<?php echo Mage::helper('core')->quoteEscape($this->__('This tab contains invalid data. Please solve the problem before saving.')) ?>"></span><?php echo $this->getTabLabel($_tab); ?></span>
         </a>
         <div id="<?php echo $this->getTabId($_tab) ?>_content" style="display:none;"><?php echo $this->getTabContent($_tab) ?></div>

app/design/adminhtml/default/default/template/widget/tabshoriz.phtml

@@ -24,22 +24,19 @@
  * @license     http://opensource.org/licenses/afl-3.0.php  Academic Free License (AFL 3.0)
  */
 ?>
-<!-- <?php if($this->getTitle()): ?>
-    <h3><?php echo $this->getTitle() ?></h3>
-<?php endif ?> -->
-<?php if(!empty($tabs)): ?>
-<ul id="<?php echo $this->getId() ?>" class="tabs-horiz">
-<?php foreach ($tabs as $_tab): ?>
-    <li>
-        <a href="<?php echo $this->getTabUrl($_tab)?>" id="<?php echo $this->getTabId($_tab) ?>" title="<?php echo $this->getTabTitle($_tab) ?>" class="tab-item-link <?php echo $this->getTabClass($_tab) ?><?php if (preg_match('/\s?ajax\s?/', $this->getTabClass($_tab))) {?> notloaded<?php }?>">
-            <span><span class="changed" title="<?php echo Mage::helper('core')->quoteEscape($this->__('The information in this tab has been changed.')) ?>"></span><span class="error" title="<?php echo Mage::helper('core')->quoteEscape($this->__('This tab contains invalid data. Please solve the problem before saving.')) ?>"></span><?php echo $this->getTabLabel($_tab) ?></span>
-        </a>
-        <div id="<?php echo $this->getTabId($_tab) ?>_content" style="display:none"><?php echo $this->getTabContent($_tab) ?></div>
-    </li>
-<?php endforeach ?>
-</ul>
-<script type="text/javascript">
 
-    <?php echo $this->getId() ?>JsTabs = new varienTabs('<?php echo $this->getId() ?>', '<?php echo $this->getDestElementId() ?>', '<?php echo $this->getActiveTabId() ?>', <?php echo $this->getAllShadowTabs()?>);
-</script>
+<?php if (!empty($tabs)): ?>
+    <ul id="<?php echo $this->getId() ?>" class="tabs-horiz">
+        <?php foreach ($tabs as $tab): ?>
+            <li>
+                <a href="<?php echo $this->getTabUrl($tab) ?>" id="<?php echo $this->getTabId($tab) ?>" title="<?php echo $this->getTabTitle($tab) ?>" class="tab-item-link <?php echo $class = $this->getTabClass($tab),((!empty($class) && preg_match('/\s?ajax\s?/', $class)) ? ' notloaded' : '') ?>">
+                    <span><span class="changed" title="<?php echo Mage::helper('core')->quoteEscape($this->__('The information in this tab has been changed.')) ?>"></span><span class="error" title="<?php echo Mage::helper('core')->quoteEscape($this->__('This tab contains invalid data. Please solve the problem before saving.')) ?>"></span><?php echo $this->getTabLabel($tab) ?></span>
+                </a>
+                <div id="<?php echo $this->getTabId($tab) ?>_content" style="display:none"><?php echo $this->getTabContent($tab) ?></div>
+            </li>
+        <?php endforeach ?>
+    </ul>
+    <script type="text/javascript">
+    <?php echo $this->getId() ?>JsTabs = new varienTabs('<?php echo $this->getId() ?>', '<?php echo $this->getDestElementId() ?>', '<?php echo $this->getActiveTabId() ?>', <?php echo $this->getAllShadowTabs() ?>);
+    </script>
 <?php endif ?>

lib/Varien/Data/Form/Element/Abstract.php

@@ -214,7 +214,7 @@ public function removeClass($class)
      */
     protected function _escape($string)
     {
-        return htmlspecialchars($string, ENT_COMPAT);
+        return is_string($string) ? htmlspecialchars($string, ENT_COMPAT) : $string;
     }
 
     /**

lib/Varien/Data/Form/Element/Multiselect.php

@@ -77,7 +77,7 @@ public function getElementHtml()
 
         $value = $this->getValue();
         if (!is_array($value)) {
-            $value = explode(',', $value);
+            $value = is_string($value) ? explode(',', $value) : [];
         }
 
         if ($values = $this->getValues()) {

lib/Varien/Io/File.php

@@ -130,7 +130,7 @@ public function streamOpen($fileName, $mode = 'w+', $chmod = 0666)
             throw new Exception('Permission denied for write to ' . $this->getFilteredPath($this->_cwd));
         }
 
-        if (!ini_get('auto_detect_line_endings')) {
+        if ((PHP_VERSION_ID < 80100) && !ini_get('auto_detect_line_endings')) {
             ini_set('auto_detect_line_endings', 1);
         }
 

lib/Varien/Object.php

@@ -340,7 +340,7 @@ public function getData($key='', $index=null)
         $default = null;
 
         // accept a/b/c as ['a']['b']['c']
-        if (strpos($key,'/')) {
+        if (is_string($key) && strpos($key, '/')) {
             $keyArr = explode('/', $key);
             $data = $this->_data;
             foreach ($keyArr as $i=>$k) {
@@ -609,7 +609,7 @@ public function toString($format='')
         } else {
             preg_match_all('/\{\{([a-z0-9_]+)\}\}/is', $format, $matches);
             foreach ($matches[1] as $var) {
-                $format = str_replace('{{'.$var.'}}', $this->getData($var), $format);
+                $format = str_replace('{{'.$var.'}}', (string) $this->getData($var), $format);
             }
             $str = $format;
         }

lib/Zend/Db/Adapter/Pdo/Abstract.php

@@ -289,6 +289,9 @@ public function exec($sql)
      */
     protected function _quote($value)
     {
+        if (is_null($value)) {
+            return "''";
+        }
         if (is_int($value) || is_float($value)) {
             return $value;
         }

lib/Zend/Db/Statement/Pdo.php

@@ -245,7 +245,7 @@ public function _execute(array $params = null)
      * @return mixed Array, object, or scalar depending on fetch mode.
      * @throws Zend_Db_Statement_Exception
      */
-    public function fetch($style = null, $cursor = null, $offset = null)
+    public function fetch($style = null, $cursor = PDO::FETCH_ORI_NEXT, $offset = 0)
     {
         if ($style === null) {
             $style = $this->_fetchMode;

lib/Zend/Locale/Data.php

@@ -340,7 +340,7 @@ public static function getList($locale, $path, $value = false)
             $val = implode('_' , $value);
         }
 
-        $val = urlencode($val);
+        $val = is_string($val) ? urlencode($val) : $val;
         $id  = self::_filterCacheId('Zend_LocaleL_' . $locale . '_' . $path . '_' . $val);
 
         // add runtime cache to avoid calling cache backend multiple times during one request
@@ -998,7 +998,8 @@ public static function getContent($locale, $path, $value = false)
         if (is_array($value)) {
             $val = implode('_' , $value);
         }
-        $val = urlencode($val);
+
+        $val = is_string($val) ? urlencode($val) : $val;
         $id  = self::_filterCacheId('Zend_LocaleC_' . $locale . '_' . $path . '_' . $val);
 
         // add runtime cache to avoid calling cache backend multiple times during one request