Improve getScheme on Zend_Controller_Request_Http

[mmenozzi]

Description (*)

Some web servers (for example the local web server of the Symfony CLI) puts the value On (and not on) in the $_SERVER['HTTPS'] super global.

With this PR the Zend_Controller_Request_Http::getScheme properly returns the HTTPS scheme in such situations.

Manual testing scenarios (*)

1. Install a clean copy of OpenMage as usual
2. Install Symfony CLI and its SSL certificates
3. Start the Symfony CLI local web server with symfony server:start
4. Configure OpenMage to use the https://127.0.0.1:8000/ base URL for both secure and unsecure
5. Try to open the home page at https://127.0.0.1:8000/
6. Without this PR you'll get "Too many redirects" error, with this PR you'll properly get the home page

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[luigifab]

With PHP 8.1, if $this->getServer('HTTPS') return null, it will crash.
strtolower(null): PHP Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated

Not sure if this case can happen.

[Flyingmana]

strtolower requires a string, but we could get a null here as of

magento-lts/app/code/core/Zend/Controller/Request/Http.php

Lines 345 to 361 in b6cc7b2

	/**
	* Retrieve a member of the $_SERVER superglobal
	*
	* If no $key is passed, returns the entire $_SERVER array.
	*
	* @param string $key
	* @param mixed $default Default value to use if key not found
	* @return mixed Returns null if key does not exist
	*/
	public function getServer($key = null, $default = null)
	{
	if (null === $key) {
	return $_SERVER;
	}
	return (isset($_SERVER[$key])) ? $_SERVER[$key] : $default;
	}

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit a1b01fa. ± Comparison against base commit 8b9bfae.