Fix multiple "PHPDoc tag @param has invalid value" phpstan errors

app/Mage.php

@@ -402,7 +402,7 @@ public static function getModuleDir($type, $moduleName)
      * Retrieve config value for store by path
      *
      * @param string $path
-     * @param mixed $store
+     * @param null|string|bool|int|Mage_Core_Model_Store $store
      * @return mixed
      */
     public static function getStoreConfig($path, $store = null)

app/code/core/Mage/Adminhtml/Block/Checkout/Agreement/Grid.php

@@ -119,7 +119,7 @@ protected function _afterLoadCollection()
     }
 
     /**
-     * @param $collection
+     * @param Varien_Data_Collection $collection
      * @param Mage_Adminhtml_Block_Widget_Grid_Column $column
      */
     protected function _filterStoreCondition($collection, $column)

app/code/core/Mage/Adminhtml/Block/Permissions/Block/Grid.php

@@ -85,7 +85,7 @@ protected function _prepareColumns()
     }
 
     /**
-     * @param $row
+     * @param Mage_Admin_Model_Block $row
      * @return string
      */
     public function getRowUrl($row)

app/code/core/Mage/Adminhtml/Block/Permissions/Variable/Grid.php

@@ -86,7 +86,7 @@ protected function _prepareColumns()
     }
 
     /**
-     * @param $row
+     * @param Mage_Admin_Model_Variable $row
      * @return string
      */
     public function getRowUrl($row)

app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items.php

@@ -72,7 +72,7 @@ public function getItems()
     /**
      * Add button to the items header
      *
-     * @param $args array
+     * @param array $args
      */
     public function addButton($args)
     {

app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php

@@ -211,8 +211,8 @@ public function getPackages()
     /**
      * Get item of shipment by its id
      *
-     * @param  $itemId
-     * @param  $itemsOf
+     * @param int $itemId
+     * @param string $itemsOf
      * @return Varien_Object
      */
     public function getShipmentItem($itemId, $itemsOf)

app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Abstract.php

@@ -111,8 +111,8 @@ public function getCondition()
 
     /**
      * @deprecated after 1.5.0.0
-     * @param  $value
-     * @return mixed
+     * @param array|string $value
+     * @return array|string
      */
     protected function _escapeValue($value)
     {

app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Currency.php

@@ -45,8 +45,8 @@ class Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Currency
     /**
      * Renders grid column
      *
-     * @param   Varien_Object $row
-     * @return  string
+     * @param Varien_Object $row
+     * @return string
      */
     public function render(Varien_Object $row)
     {
@@ -69,7 +69,7 @@ public function render(Varien_Object $row)
     /**
      * Returns currency code, false on error
      *
-     * @param $row
+     * @param Varien_Object $row
      * @return string|false
      */
     protected function _getCurrencyCode($row)
@@ -86,7 +86,7 @@ protected function _getCurrencyCode($row)
     /**
      * Get rate for current row, 1 by default
      *
-     * @param $row
+     * @param Varien_Object $row
      * @return float|int
      */
     protected function _getRate($row)

app/code/core/Mage/Adminhtml/Model/LayoutUpdate/Validator.php

@@ -169,7 +169,7 @@ protected function _getXpathBlockValidationExpression()
      * Validate template path for preventing access to the directory above
      * If template path value has "../" @throws Exception
      *
-     * @param $templatePaths | array
+     * @param array $templatePaths
      */
     protected function _validateTemplatePath(array $templatePaths)
     {

app/code/core/Mage/Api2/Model/Dispatcher.php

@@ -80,7 +80,7 @@ public function dispatch(Mage_Api2_Model_Request $request, Mage_Api2_Model_Respo
     /**
      * Pack resource model class path from components and try to load it
      *
-     * @param $model
+     * @param string $model
      * @param string $apiType API type
      * @param string $userType API User type (e.g. admin, customer, guest)
      * @param int $version Requested version

app/code/core/Mage/Api2/Model/Resource.php

@@ -293,7 +293,7 @@ public function dispatch()
     /**
      * Trigger error for not-implemented operations
      *
-     * @param $methodName
+     * @param string $methodName
      */
     protected function _errorIfMethodNotExist($methodName)
     {
@@ -305,7 +305,7 @@ protected function _errorIfMethodNotExist($methodName)
     /**
      * Check method exist
      *
-     * @param $methodName
+     * @param string $methodName
      * @return bool
      */
     protected function _checkMethodExist($methodName)

app/code/core/Mage/Authorizenet/Helper/Data.php

@@ -83,7 +83,7 @@ public function getSaveOrderUrlParams($controller)
 
     /**
      * Retrieve redirect iframe url
-     * @param $params
+     * @param array $params
      * @return string
      */
     public function getRedirectIframeUrl($params)

app/code/core/Mage/Backup/Model/Resource/Db.php

@@ -138,7 +138,7 @@ public function getTableForeignKeysSql($tableName = null)
      * Retrieve table status
      *
      * @param string $tableName
-     * @return Varien_Object
+     * @return Varien_Object|false
      */
     public function getTableStatus($tableName)
     {
@@ -168,7 +168,7 @@ public function getTableStatus($tableName)
      *
      * @param string $tableName
      * @param array $row
-     * @return string
+     * @return array
      */
     protected function _quoteRow($tableName, array $row)
     {
@@ -191,9 +191,9 @@ public function getTableDataSql($tableName, $count = null, $offset = null)
     /**
      * Enter description here...
      *
-     * @param unknown_type $tableName
-     * @param unknown_type $addDropIfExists
-     * @return unknown
+     * @param string $tableName
+     * @param bool $addDropIfExists
+     * @return string
      */
     public function getTableCreateScript($tableName, $addDropIfExists = false)
     {
@@ -203,7 +203,7 @@ public function getTableCreateScript($tableName, $addDropIfExists = false)
     /**
      * Retrieve table header comment
      *
-     * @param unknown_type $tableName
+     * @param string $tableName
      * @return string
      */
     public function getTableHeader($tableName)
@@ -306,7 +306,7 @@ public function rollBackTransaction()
     /**
      * Run sql code
      *
-     * @param $command
+     * @param string|Zend_Db_Select $command
      * @return $this
      */
     public function runCommand($command){

app/code/core/Mage/Catalog/Block/Product/List.php

@@ -215,7 +215,7 @@ public function getToolbarHtml()
     }
 
     /**
-     * @param $collection
+     * @param Mage_Catalog_Model_Resource_Product_Collection $collection
      * @return $this
      */
     public function setCollection($collection)
@@ -225,7 +225,7 @@ public function setCollection($collection)
     }
 
     /**
-     * @param $code
+     * @param array|string|integer|Mage_Core_Model_Config_Element $code
      * @return $this
      * @throws Mage_Core_Exception
      */

app/code/core/Mage/Catalog/Block/Product/View/Options.php

@@ -34,6 +34,9 @@
  */
 class Mage_Catalog_Block_Product_View_Options extends Mage_Core_Block_Template
 {
+    /**
+     * @var Mage_Catalog_Model_Product
+     */
     protected $_product;
 
     protected $_optionRenders = array();
@@ -111,7 +114,7 @@ public function getOptionRender($type)
     }
 
     /**
-     * @param $type
+     * @param string $type
      * @return string
      */
     public function getGroupOfOption($type)

app/code/core/Mage/Catalog/Block/Product/View/Tabs.php

@@ -39,7 +39,7 @@ class Mage_Catalog_Block_Product_View_Tabs extends Mage_Core_Block_Template
     /**
      * Add tab to the container
      *
-     * @param $alias
+     * @param string $alias
      * @param string $title
      * @param string $block
      * @param string $template

app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php

@@ -54,7 +54,7 @@ class Mage_Catalog_Model_Api2_Product_Validator_Product extends Mage_Api2_Model_
 
     /**
      * Mage_Catalog_Model_Api2_Product_Validator_Product constructor.
-     * @param $options
+     * @param array $options
      * @throws Exception
      */
     public function __construct($options)

app/code/core/Mage/Catalog/Model/Config.php

@@ -281,7 +281,7 @@ public function getProductTypeName($id)
     }
 
     /**
-     * @param $source
+     * @param Mage_Eav_Model_Entity_Attribute_Source_Interface $source
      * @param string $value
      * @return string|null
      */

app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php

@@ -398,7 +398,7 @@ public function parse()
     }
 
     /**
-     * @param $items
+     * @param array $items
      */
     public function setInventoryItems($items)
     {

app/code/core/Mage/Catalog/Model/Entity/Product/Attribute/Frontend/Image.php

@@ -35,7 +35,7 @@
 class Mage_Catalog_Model_Entity_Product_Attribute_Frontend_Image extends Mage_Eav_Model_Entity_Attribute_Frontend_Abstract
 {
     /**
-     * @param $object
+     * @param Varien_Object $object
      * @param string $size
      * @return bool|string
      */

app/code/core/Mage/Catalog/Model/Product/Condition.php

@@ -52,7 +52,7 @@ public function applyToCollection($collection)
 
     /**
      * @param Magento_Db_Adapter_Pdo_Mysql $dbAdapter
-     * @return string
+     * @return string|Varien_Db_Select
      */
     public function getIdsSelect($dbAdapter)
     {

app/code/core/Mage/Catalog/Model/Product/Condition/Interface.php

@@ -34,7 +34,7 @@ public function applyToCollection($collection);
 
     /**
      * @param Magento_Db_Adapter_Pdo_Mysql $dbAdapter
-     * @return string
+     * @return string|Varien_Db_Select
      */
     public function getIdsSelect($dbAdapter);
 }

app/code/core/Mage/Catalog/Model/Product/Type.php

@@ -169,7 +169,7 @@ public static function getOptions()
     }
 
     /**
-     * @param $optionId
+     * @param string $optionId
      * @return mixed|null
      */
     public static function getOptionText($optionId)

app/code/core/Mage/CatalogIndex/Model/Indexer.php

@@ -814,8 +814,8 @@ public function prepareCatalogProductFlatIndexes(Varien_Object $object)
     /**
      * Update price process for catalog product flat
      *
-     * @param $store
-     * @param mixed $products
+     * @param Mage_Core_Model_Store|int $store
+     * @param Mage_Catalog_Model_Product|int|array|null $products
      * @param string $resourceTable
      * @return $this
      */

app/code/core/Mage/CatalogIndex/Model/Resource/Indexer.php

@@ -87,7 +87,7 @@ protected function _loadAttribute($id)
      * @param bool $minimal clear minimal price index data flag
      * @param bool $finalPrice clear final price index data flag
      * @param bool $tierPrice clear tier price index data flag
-     * @param mixed $products applicable products
+     * @param Mage_Catalog_Model_Product|Mage_Catalog_Model_Product_Condition_Interface|int|array|null $products applicable products
      * @param mixed $store applicable stores
      */
     public function clear(
@@ -640,7 +640,7 @@ public function prepareCatalogProductFlatIndexes(Varien_Object $object)
      * Update prices for Catalog Product flat
      *
      * @param int $storeId
-     * @param array $productIds
+     * @param array|Mage_Catalog_Model_Product_Condition_Interface $productIds
      * @param string $tableName
      * @return $this
      */

app/code/core/Mage/Checkout/Block/Cart/Totals.php

@@ -42,7 +42,7 @@ public function getTotals()
     }
 
     /**
-     * @param $value
+     * @param array $value
      * @return $this
      */
     public function setTotals($value)
@@ -52,7 +52,7 @@ public function setTotals($value)
     }
 
     /**
-     * @param $code
+     * @param string $code
      * @return false|Mage_Core_Block_Abstract|string
      */
     protected function _getTotalRenderer($code)

app/code/core/Mage/Checkout/controllers/OnepageController.php

@@ -687,7 +687,7 @@ protected function _canShowForUnregisteredUsers()
     /**
      * Prepare JSON formatted data for response to client
      *
-     * @param $response
+     * @param mixed $response
      * @return Zend_Controller_Response_Abstract
      */
     protected function _prepareDataJSON($response)

app/code/core/Mage/Core/Block/Abstract.php

@@ -898,8 +898,8 @@ protected function _beforeToHtml()
     /**
      * Specify block output frame tags
      *
-     * @param $openTag
-     * @param $closeTag
+     * @param string $openTag
+     * @param string $closeTag
      * @return $this
      */
     public function setFrameTags($openTag, $closeTag = null)

app/code/core/Mage/Core/Model/Config.php

@@ -1050,8 +1050,8 @@ public function getDistroServerVars()
     }
 
     /**
-     * @param $data
-     * @return mixed
+     * @param string|array $data
+     * @return array|string
      */
     public function substDistroServerVars($data)
     {

app/code/core/Mage/Core/Model/Email/Template/Filter.php

@@ -510,7 +510,7 @@ public function customvarDirective($construction)
      * Syntax: {{inlinecss file=""}}  If this directive is used, the file will be stored on this object so that
      * it can be retrieved later
      *
-     * @param $construction
+     * @param array $construction
      * @return string
      */
     public function inlinecssDirective($construction)
@@ -525,7 +525,7 @@ public function inlinecssDirective($construction)
     /**
      * Set filename of CSS file to inline
      *
-     * @param $filename
+     * @param string $filename
      * @return $this
      */
     protected function _setInlineCssFile($filename)