Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple "PHPDoc tag @param has invalid value" phpstan errors #2227

Merged
merged 1 commit into from Jun 14, 2022
Merged

Fix multiple "PHPDoc tag @param has invalid value" phpstan errors #2227

merged 1 commit into from Jun 14, 2022

Conversation

tmotyl
Copy link
Contributor

@tmotyl tmotyl commented Jun 14, 2022 •
edited

Description (*)

Fixes some issues reported by phpstan

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Backup Relates to Mage_Backup Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Install Relates to Mage_Install Component: Oauth Relates to Mage_Oauth Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Rss Relates to Mage_Rss Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Tax Relates to Mage_Tax Component: Uploader Relates to Mage_Uploader Component: Wishlist Relates to Mage_Wishlist environment Mage.php Relates to app/Mage.php labels Jun 14, 2022
@fballiano fballiano merged commit fad62b5 into OpenMage:1.9.4.x Jun 14, 2022
@github-actions
Copy link

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit fad62b5. ± Comparison against base commit abecbc1.

@tmotyl
Copy link
Contributor Author

tmotyl commented Jun 14, 2022

Wow that was fast! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Backup Relates to Mage_Backup Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Install Relates to Mage_Install Component: Oauth Relates to Mage_Oauth Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Rss Relates to Mage_Rss Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Tax Relates to Mage_Tax Component: Uploader Relates to Mage_Uploader Component: Wishlist Relates to Mage_Wishlist environment Mage.php Relates to app/Mage.php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmotyl @fballiano @ADDISON74