Fix creditmemo tax calculation bug when using multiple discounts (again) #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace
$creditmemo->setGrandTotal($creditmemo->getGrandTotal() + $subtotal);
$creditmemo->setBaseGrandTotal($creditmemo->getBaseGrandTotal() + $baseSubtotal);
with
$creditmemo->setGrandTotal($creditmemo->getGrandTotal() + $subtotalInclTax);
$creditmemo->setBaseGrandTotal($creditmemo->getBaseGrandTotal() + $baseSubtotalInclTax);
|
@tmotyl Can you access now? It has been a while since I made these changes. Also need to dive in again. This is why I also asked for confirmation from other testers/people that work with credit memo |
|
yes, it's editable now |
|
From #88
Please correct me, but magento does not support multiple discount codes by default. |
sreichel
reviewed
Jan 11, 2018
| $creditmemo->setGrandTotal($creditmemo->getGrandTotal() + $subtotal); | ||
| $creditmemo->setBaseGrandTotal($creditmemo->getBaseGrandTotal() + $baseSubtotal); | ||
| $creditmemo->setGrandTotal($creditmemo->getGrandTotal() + $subtotalInclTax); | ||
| $creditmemo->setBaseGrandTotal($creditmemo->getBaseGrandTotal() + $baseSubtotalInclTax); | ||
|
|
There was a problem hiding this comment.
Is this tested with different tax settings?
|
@sreichel You are correct, Magento does not support multiple coupon codes. |
|
So it should be fixed in 3rd-party code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from #88 / maybe can be edited now