Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid to use unavailable $data var in Curl HTTP Client #2785

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Avoid to use unavailable $data var in Curl HTTP Client #2785

merged 1 commit into from
Dec 5, 2022

Conversation

maximehuran
Copy link
Contributor

@maximehuran maximehuran commented Dec 5, 2022 •
edited by sreichel
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: lib/Mage Relates to lib/Mage Component: lib/* Relates to lib/* labels Dec 5, 2022
@maximehuran maximehuran requested review from fballiano and sreichel and removed request for fballiano and sreichel December 5, 2022 21:07
@maximehuran
Copy link
Contributor Author

Thank you for your fast review 🚀 ❤️

@sreichel sreichel merged commit 792095c into OpenMage:1.9.4.x Dec 5, 2022
@maximehuran maximehuran deleted the patch-1 branch December 6, 2022 08:36
fballiano pushed a commit to fballiano/openmage that referenced this pull request Dec 6, 2022
@maximehuran @fballiano
Avoid to use unavailable $data var in Curl HTTP Client (OpenMage#2785)
aef696f
sreichel added a commit that referenced this pull request Dec 6, 2022
Fixed baseline, ref #2785
27d0f22
fballiano pushed a commit that referenced this pull request Dec 7, 2022
PHPStan: Fixed baseline, ref #2785 (#2789)
dc3df89
fballiano pushed a commit to fballiano/openmage that referenced this pull request Dec 7, 2022
@sreichel @fballiano
PHPStan: Fixed baseline, ref OpenMage#2785 (OpenMage#2789)
1d0c5ce
fballiano pushed a commit that referenced this pull request Dec 19, 2022
@maximehuran @fballiano
Avoid to use unavailable $data var in Curl HTTP Client (#2785)
0d85a8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@sreichel sreichel sreichel approved these changes

Assignees
No one assigned
Labels
Component: lib/Mage Relates to lib/Mage Component: lib/* Relates to lib/*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maximehuran @fballiano @sreichel