Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed baseline, ref #2785 #2789

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Fixed baseline, ref #2785 #2789

merged 1 commit into from
Dec 7, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 6, 2022 •
edited

Description (*)

Related issues was fixed before lib/Mage was added to phpstan checks. Updated baseline.

Related Pull Requests

  1. See Avoid to use unavailable $data var in Curl HTTP Client #2785

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@fballiano fballiano merged commit dc3df89 into 1.9.4.x Dec 7, 2022
@fballiano fballiano deleted the fix/phpstan--baseline branch December 7, 2022 09:26
fballiano pushed a commit to fballiano/openmage that referenced this pull request Dec 7, 2022
@sreichel @fballiano
PHPStan: Fixed baseline, ref OpenMage#2785 (OpenMage#2789)
1d0c5ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

@fballiano fballiano Awaiting requested review from fballiano

Assignees
No one assigned
Labels
phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sreichel @kiatng @ADDISON74 @fballiano