Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpstan: step back to level 4 #2837

Merged
merged 1 commit into from
Dec 23, 2022
Merged

phpstan: step back to level 4 #2837

merged 1 commit into from
Dec 23, 2022

Conversation

sreichel
Copy link
Contributor

Description (*)

Think we made good progess. If we achieve L2/3/4 without ignoring/baseline errors, it would be great. Setting checks to L5 was to optimistic ... I already spent "hours", but without any help it is just to much.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@fballiano fballiano merged commit 7f6e32d into OpenMage:1.9.4.x Dec 23, 2022
@tmotyl
Copy link
Contributor

tmotyl commented Dec 23, 2022

@sreichel In my opinion level 5 was ok to keep, (even with big baseline) because it prevents new code from introducing new errors.

fballiano pushed a commit to fballiano/openmage that referenced this pull request Dec 23, 2022
@sreichel sreichel deleted the phpstan/level4 branch December 23, 2022 17:06
@sreichel
Copy link
Contributor Author

because it prevents new code from introducing new errors.

For this reason i've reverted that ignored errors. Level5 adds ~1000 errors to baseline.

Better l4 w/o ignoring something and fix existing ones. We still have +30 errors at level 0, that should be investigated.

fballiano pushed a commit to fballiano/openmage that referenced this pull request Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants