Better exceptions for file upload #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: lib/Varien
Sdfendor
approved these changes
Jan 6, 2023
ADDISON74
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
I agree with this PR for better error management in the case of uploading images. The explanatory phrases were not created but taken from here, which is fine
https://www.php.net/manual/en/features.file-upload.errors.php
elidrissidev
approved these changes
Jan 6, 2023
fballiano
added a commit
that referenced
this pull request
Jan 6, 2023
* Better exceptions for file upload * PHPCS fixes * PHPCS fixes
|
cherry-picked to branch 20.0 since there were no conflicts |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1313 was closed because the author couldn't fix it I've rewrote it and posted it.
This PR adds some exception messages in case of uploading error.
Messages and constant name/values are taken from https://www.php.net/manual/en/features.file-upload.errors.php