Fix exception logged when no Category image is uploaded

[elidrissidev]

Description (*)

As @luigifab pointed out in #3025 (comment), updating a Category without an image keeps logging an exception "No file was uploaded" in exception.log.

This error is normally being ignored by checking $e->getCode() because the Category image is optional, but the new error handling introduced in #2902 isn't passing the error code with the Exception object making the exception be logged.

Related Pull Requests

• See Better exceptions for file upload #2902

Manual testing scenarios (*)

1. Make sure logs are enabled.
2. Go to Catalog -> Categories and try to save any category, then check exception.log file.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[elidrissidev]

Got rid of the devil number ;), now TMP_NAME_EMPTY is deprecated and replaced with UPLOAD_ERR_NO_FILE so not breaking BC as long as extensions are using the constant.

[fballiano]

merged and 20ed