Wrap WHERE condition in parens #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Combine condition is utilized (e.g. via getProductFlatSelect), this commit fixes the logic when using multiple WHERE clauses.
Flyingmana
approved these changes
Jan 21, 2023
fballiano
approved these changes
Jan 21, 2023
fballiano
pushed a commit
that referenced
this pull request
Jan 21, 2023
…ndition/Combine.php (#2965)
|
merged and cherrypicked to v20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When utilizing
getProductFlatSelect(), we ran into a bug inMage_Rule_Model_Condition_Combine::prepareConditionSql()in which the WHERE clause construction did not properly parenthesize the conditions. As an example:Pre-fix:
Post-fix:
This PR ensures each where clause addition is properly contained and evaluated.