Rewrote afterSave of product and category image attributes #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to override extensions and models
luigifab
changed the title
empiricompany
approved these changes
Jul 7, 2023
|
tested on php 7.4 |
fballiano
previously approved these changes
Jul 15, 2023
6 tasks
fballiano
reviewed
Jul 16, 2023
app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Backend/Image.php
Outdated
Show resolved
Hide resolved
fballiano
reviewed
Jul 16, 2023
app/code/core/Mage/Catalog/Model/Category/Attribute/Backend/Image.php
Outdated
Show resolved
Hide resolved
fballiano
approved these changes
Jul 16, 2023
fballiano
requested review from
empiricompany,
ADDISON74 and
elidrissidev
and removed request for
empiricompany
ADDISON74
approved these changes
Jul 16, 2023
fballiano
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For catalog and category image attributes, this PR allow to:
Mage_Core_Model_File_Uploaderlikecore/file_validator_image$_FILESis empty (see Fix exception logged when no Category image is uploaded #3086)Tested with PHP 8.0 and 8.2.
Contribution checklist