Mage_Usa: added "USPS Ground Advantage" and removed "First Class Package" #3413
Conversation
fballiano
changed the title
|
Untested? Just to have another commit? |
This response has no substance and contains apparently a personal attack, see this as a Warning for a Code of Conduct Violation |
|
It's only a way to take a user's discussion (you can read that there were interactions in order to understand what we should do) and put it into code in order not to let it be forgotten. |
Thats just wrong. Why to commit untested code? Cant understand ... QA? |
|
We focus the discussion on the word "untested" instead of losing sight of the big picture. When I came here, I kept hearing very often the phrase "if you have an idea, create a PR" from the maintenance side. I believe that any proposed PR starts from the beginning with some predetermined conditions such as: it is not a problem in the code, yes it is a problem but it does not solve it. Here, everyone can be the devil's advocate and do well as long as he has solid arguments. Fabrizio took a code suggested by someone and mentioned that it is untested. In order for this PR to be approved, it needs at least 2 green, 1 green and 2 gray approvals. As you can see, no one has approved it, if they do, it means that they have tested it and can provide feedback. The fact that he opened it is beneficial, those with similar problems can checkout and determine if something is solved or not. Let's not get attached to one word in a sentence. I pretend that we are mature people. |
|
tested with a customer which confirms this patch solves the problem! 
this should be released as soon as possible because at the moment whoever's using USPS is missing on the cheaper shipping options and it is a big deal. |
|
@fballiano this is great, thanks for doing it! |
|
it seems we have 2 positive tests, can we please try to merge this? |
|
@johnvoncolln could you please approve this PR at this link: https://github.com/OpenMage/magento-lts/pull/3413/files clicking the green button on the right? Without enough votes I can't merge it and release it. In this case, having a broken USPS module is a disservice we should fix, we have the fix and we get stuck forever on such a minor thing. |
There was a problem hiding this comment.
Agreed with @fballiano to merge as First-Class will be deprecated in September.
Untested, taken from #3300 (comment)