Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovered some lost deprecated notice in #3552 #3558

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

fballiano
Copy link
Contributor

In #3555 it was noted that we lost some notation, this PR should recover them, without using the phpblock-template funcionality.

Notes:

  • I didn't recover the tags that were just descriptions because they are extremely general and seems not useful to me
  • I didn't recover (at the moment) some "type array" notation (most of them are in app/code/core/Mage/PaypalUk/Model/Api/Nvp.php) because the arrays have a clear array definition so I don't think we need to have those comments, not even for phpdoc
  • same thing for some "type mixed" like in app/code/core/Mage/PaypalUk/Model/Api/Nvp.php because, sincerely, they don't even seem correct from the start

open to suggestions

@github-actions github-actions bot added Component: Tax Relates to Mage_Tax Component: Oauth Relates to Mage_Oauth Component: Install Relates to Mage_Install labels Sep 27, 2023
@Flyingmana Flyingmana merged commit 5a7fd00 into OpenMage:main Sep 30, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Install Relates to Mage_Install Component: Oauth Relates to Mage_Oauth Component: Tax Relates to Mage_Tax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants